search

christopher-dG / gpymusic

Google Py Music: A simple TUI client for Google Play Music
MIT License
200 stars 13 forks source link

Log 'nowplaying' track to file #41

Closed nickspoons closed 6 years ago

nickspoons commented 6 years ago

I don't know if you're at all interested in merging this, but it's a feature I wanted (for displaying currently playing track in i3blocks) so I added it for myself.

When configured, the current track will be logged to a file, allowing the user the display the music status externally, e.g. as a status bar element or system notification.

christopher-dG commented 6 years ago

I think you may have forgotten to check in a file, should there by a nowplaying.py at the package root?

nickspoons commented 6 years ago

Oops ... yes there should. And I've shut everything down for the night, it'll have to wait until the morning, sorry about that.

christopher-dG commented 6 years ago

Haha no problem 🙂. It's a good feature though, I thought about adding it too.

As a side note, I'm beginning the slow process of redesigning/rebuilding this project so it might not be worth investing too much time into adding features at the moment (although I do appreciate the PRs).

nickspoons commented 6 years ago

Yeah I saw that you were working on an overhaul. That's fine, I'm just tweaking to support my own preferences, and merging back anything useable. But I think I'm done for now anyway!

nickspoons commented 6 years ago

Checked in the missing file, thanks @christopher-dG

nickspoons commented 6 years ago

I fixed the README formatting. Are you happy with config values nowplaying and filename or would you prefer camelCase or snake_case or something? What about the default file ~/.nowplaying?

christopher-dG commented 6 years ago

The naming is fine with me. Thanks for your contributions!