search

christopher-ramirez / secretary

Take the power of Jinja2 templates to OpenOffice and LibreOffice.
Other
190 stars 48 forks source link

Various fixes #1

Closed armonge closed 11 years ago

armonge commented 11 years ago

Removing a lot of global state, the code should be more testable this way. Also renamed the module file to secretary, this way it's easier to make a package out of it and subimt to pypi

christopher-ramirez commented 11 years ago

Thanks @armonge! But I can't not understand why renaming __init__.py to secretary.py to make a package in commit 2d89aabf1a1758e8844f8576e4b425a067da325a. Actually I'm new to this. Is it not necessary an __init__ file to make a Python module/package?

Thanks!

armonge commented 11 years ago

@christopher-ramirez if you we're to package and keep the __init__.py name you would have to create a new package inside the repo and have an structure like this:

setup.py
README.md
.gitignore
secretary
└── __init__.py

If we rename it to secretary.py then we only need a flat structure like

setup.py
README.md
.gitignore
secretary.py

You can see an example of this in https://github.com/kennethreitz/dj-database-url but the bottom line is that the whole thing is only a module with no need for a package (package meaning a directory with an __init__.py)