search

christopher-ramirez / secretary

Take the power of Jinja2 templates to OpenOffice and LibreOffice.
Other
190 stars 48 forks source link

Improve XML errors detection #42

Closed liberforce closed 6 years ago

liberforce commented 7 years ago

Raising a new exception makes it hard to track where the initial one was raised

liberforce commented 7 years ago

Sorry, last commit is unrelated, I'm still new at github pull requests...

christopher-ramirez commented 7 years ago

I've merged the first two commits. The last one out of the scope of this Pull Request. Also, I'm not sure if the last commit actually resolves a problem. Will have to try with pip packaging in the future. I'm planning to create a __init__.py in the root of the project. That may solves the problem.

liberforce commented 7 years ago

The problem it solves is in the commit message: « This specially allows to import and use the package with its real name when using an interactive python shell, or just run scripts from toplevel that will be able to find the package.»

I don't want to use "import src", I want to "import secretary".

Following the packaging best practice will help distribution and inclusion as a third-party package. https://python-packaging-user-guide.readthedocs.io/tutorials/distributing-packages/#your-package