christopher-ramirez / secretary

Take the power of Jinja2 templates to OpenOffice and LibreOffice.
Other
190 stars 48 forks source link

Update to 0.2.8 broke table template #55

Open gordol opened 6 years ago

gordol commented 6 years ago

I'm not sure what's happening here, but some table elements are obviously working fine... but others are broken.

I updated from 0.2.7 to 0.2.19 and noticed the issue, then started working my way back till it worked. Unfortunately, 0.2.7 was the last version that worked, and 0.2.8 is the one that broke it.

0.2.8: Fix #25. Some internal refactorings. Drop the minimal support for Jinja tags in plain text.

I am not using Jinja in plaintext... I'm indeed using InputFields, as you can see in the template.

I can email the template, but am not comfortable sharing it publicly.

Here's a high level view of the template and output: template vs output

Here's a close-up of the problematic area... template vs output

This worked fine previously, in version 0.2.7.

There's also an issue lower down, where one of the tables has an extra border that is not present in the template...

template vs output

template vs output

Am I doing something wrong? Or is this a regression?

gordol commented 6 years ago

Here's a question... Do the control flow tags have to live in separate input fields? As in, do the opening, body, and content need to be in different inputs? Hmm... I'm gonna try that as a quick change to see.

gordol commented 6 years ago

Do the control flow tags have to live in separate input fields?

YES! That was it...

Whew.

Can we get that in the docs somewhere maybe?

gordol commented 6 years ago

Still can't figure out that border issue on that oen column though...

christopher-ramirez commented 6 years ago

Hello! I've never seen a issue like this with the borders. I can see that the issue is also present on the table headers, which is static, as I see on your template.

Can you check the border settings on this table? Also, this is issue is present in any other table of the document?

gordol commented 6 years ago

Hi thanks for your feedback. Hmm, if it was static why would updating secretary make it appear suddenly?

On Jan 26, 2018 08:54, "Christopher Ramírez" notifications@github.com wrote:

Hello! I've never seen a issue like this with the borders. I can see that the issue is also present on the table headers, which is static, as I see on your template.

Can you check the border settings on this table? Also, this is issue is present in any other table of the document?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/christopher-ramirez/secretary/issues/55#issuecomment-360790410, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgCNefk3EUYi8BT0Z2QnIYIN9OenY32ks5tOdkNgaJpZM4RtOGe .

christopher-ramirez commented 6 years ago

Sorry but I could not reproduce this issue using the latest Secretrary release.

Can you try once again, now merging the all cells in the rows used by the loop tags?

christopher-ramirez commented 6 years ago

Any update on this?

gordol commented 6 years ago

Merging the cells had no effect. Sorry for the late response.

gordol commented 6 years ago

I'm on vacation this week, but soon I'll try building a static array of data to input to a stripped down version of this template, and see if I can get something reproducible.

gordol commented 4 years ago

Hey guys,

A buddy from Alabama is flying out here to go camping with me this weekend. He's in town Thursday->Monday.

There is cell service out there, but not sure if my carrier is out there, so I'll take my satellite messenger, and I'll have my laptop locked in the car, and can make it to a nearby town to get wifi if there's an emergency or something. If there's no service, you will both get texts from me over the satellite messenger, so you can easily respond, etc...

Things should be fine though, I'm pretty hands-off with the infrastructure these days, it's very stable. I just restart the services occassionally as a preventative measure. Currently production has been up and running for ~50 days without a restart, so I'll give it a full refresh this week just to ensure everything is running smoothly while I'm gone.

I should be leaving here early Friday morning and getting back late Sunday night, and will be available if/as needed Thursday/Monday, just gotta run my buddy from/to the airport.

-- Thomas Gordon Lowrey IV Software Systems Engineer / Developer 205.409.4901 https://www.linkedin.com/in/gordol