christopher5106 / last_caffe_with_stn

Spatial Transformer Networks
Other
76 stars 42 forks source link

Is there a error in st_layer.cpp? #7

Closed ChinaZhuK closed 6 years ago

ChinaZhuK commented 6 years ago

In line 116, it is: Dtype data = output_grid.mutable_cpu_data(); for(int i=0; i< outputH outputW; ++i) { data[3 i] = (i / outputW) 1.0 / outputH 2 - 1; data[3 i + 1] = (i % outputW) 1.0 / outputW 2 - 1; data[3 i + 2] = 1; } But I think it may should be: Dtype data = output_grid.mutable_cpu_data(); for(int i=0; i< outputH outputW; ++i) {
data[3
i] = (i % outputW) 1.0 / (outputW-1) 2 - 1; data[3 i + 1] = (i / outputW) 1.0 / (outputH-1) 2 - 1; data[3 i + 2] = 1; } It should be (x, y, 1) instead of (y, x, 1), and -1 makes the (1, 1, 1) possible.