christopherabouabdo / react-native-photo-grid

MIT License
36 stars 14 forks source link

breaks on reactNative 26 and react 15.0.2 #1

Open folivi opened 8 years ago

folivi commented 8 years ago

hi, very conveniant package! Just one issue I ran into after updating RN. It works great in rn 0.25 but breaks on line 66 in Photogrid.js { items.map(item => this.props.renderItem(item, itemWidth)) } with the error message: Super expression must either be null or a function, not undefined in rn 26.

christopherabouabdo commented 8 years ago

This is likely related to the separation of React and react-native in 0.25. I'm guessing this:

import React from 'react-native';

let {
  Dimensions,
  ListView,
  StyleSheet,
  View,
} = React;

class PhotoGrid extends React.Component {

  constructor() {
    super();

should look more like this:

import {
  Component,
  Dimensions,
  ListView,
  StyleSheet,
  View,
} from 'react-native';

class PhotoGrid extends Component {

  constructor() {
    super();

I'm deep in some other work right now so if you want to do some testing/create a PR that would be awesome. Otherwise I'll try to get around to it soon.