search

christopheradams / elixir_style_guide

A community driven style guide for Elixir
4.37k stars 299 forks source link

Update spanish translation #192

Closed iver closed 4 years ago

iver commented 4 years ago

I updated the spanish version with the latest changes. Is it ok if I send my PR to this repository or should be requested to @albertoalmagro's repository?

albertoalmagro commented 4 years ago

@iver this one is the correct repository.

Edit: I think it would be better if we can host translations in this repo, that way we could see changes in a single place.

iver commented 4 years ago

@albertoalmagro sure! ... my first PR was with a change using i18n directory, but @christopheradams has a good point about the review, each language translation require more supervision by someone with respective language knowledge.

christopheradams commented 4 years ago

Thanks @iver for the Spanish language updates. And for understanding I'm not able to host all translations and keep up with their commits and issues.

albertoalmagro commented 4 years ago

If the desire was to have the translations reviewed then I believe the correct process would have been sending a pull request to my repo so that we could create a pull request and review it. Cheers!

christopheradams commented 4 years ago

@albertoalmagro I see I jumped to the conclusion that @iver was stepping up to maintain the Spanish translation and that I should point to his fork (which is what this PR does). That may have been wrong on my part. Do you intend to keep yours up to date? You should have preference here. :)