search

christopherafbjur / sanity-plugin-icon-picker

MIT License
29 stars 22 forks source link

DeprecationWarning: Invalid `main` field #25

Closed chandlervdw closed 1 year ago

chandlervdw commented 2 years ago

When running sanity graphql deploy:

DeprecationWarning: Invalid 'main' field in '../node_modules/sanity-plugin-icon-picker/node_modules/react-icons/package.json' of 'lib'. Please either fix that or report it to the module author
codingChewie commented 1 year ago

Any status on this and if React Icons will be upgraded from version:

4.2.0

to:

4.5.1

as this error would appear to be causing a Netlify build failure as the terminal error prompts to proceed from Sanity and because that isnt an option it then results in an error of:

Build failed - Command failed with exit code 134

On research of the exit code 134 there is a linked forum article mentioning this error could be causing a memory leak. Upgrading versions will also resolve the PR for adding Simple Icons.

christopherafbjur commented 1 year ago

Thank you for reporting this and sorry for the delay. I will start looking into fixing these recent issues asap!

codingChewie commented 1 year ago

Thank you for reporting this and sorry for the delay. I will start looking into fixing these recent issues asap!

Just curious if you would be upgrading to Sanity v3?

christopherafbjur commented 1 year ago

Thank you for reporting this and sorry for the delay. I will start looking into fixing these recent issues asap!

Just curious if you would be upgrading to Sanity v3?

Yes that's something I will do as well. Just haven't decided if I will do that in the same release. Might be better to fix this first for backward compatibility and create a new release for v3