search

christopherafbjur / sanity-plugin-icon-picker

MIT License
29 stars 22 forks source link

Stored SVG is not available in GraphQL #49

Closed JJK801 closed 1 year ago

JJK801 commented 1 year ago

hi @christopherafbjur ,

I updated my plugin today to use the new storeSvg feature (thanks again for the work)

But it seems like svg propertie es not available in graphQL types (probably because it requires a field in the schema type).

christopherafbjur commented 1 year ago

Hi @JJK801,

Can you please provide me some more context of your issue? Not sure I understand why SVG properties should be available in GraphQL types. Should it not suffice with String type since we store the svg as a string?

JJK801 commented 1 year ago

@christopherafbjur ,

Sorry, i think my message wasn't clear enough.

My point is that svg field (containing inline svg) isn't exposed at all on the GraphQL iconPicker type.

Capture d’écran 2023-06-16 à 12 43 26

christopherafbjur commented 1 year ago

Thank you @JJK801! Yes you are correct that it's missing the field in the schema. With this new feature we never updated the schema. Will have a look at this next week.

JJK801 commented 1 year ago

That what i assumed, i can make a PR if you want

christopherafbjur commented 1 year ago

@JJK801 Yes you're very welcome to do so 👍