search

christophercliff / metalsmith-fingerprint

A fingerprint plugin for Metalsmith
MIT License
28 stars 7 forks source link

full working support of windows system #9

Closed oupala closed 8 years ago

oupala commented 9 years ago

The real support of windows system needs another modification. Sorry for not having seen that on the first pull request.

oupala commented 8 years ago

@christophercliff The previous pull request was actually not working on windows.

This pull request aims at fixing this lack definetly.

oupala commented 8 years ago

@christophercliff do you have an opinion on the pull request?

oupala commented 8 years ago

@christophercliff is there a problem with my pull request?

I'm ok to modify my pull request if you give me some clues.

christophercliff commented 8 years ago

Is there a way to verify this fix with automated testing? I don't want a repeat of https://github.com/christophercliff/metalsmith-fingerprint/issues/7.

oupala commented 8 years ago

Hello @christophercliff I have to apologize for having asked you so much. In fact, I read my test result in a wrong way and it appears that #7 is working.

My test cases shows that it works on linux but not on windows. But what I had to read and understand from the previous sentence, is that the linux syntax work on windows but the old-wordkaround-windows-syntax do not work any more on windows. And that's a good thing that the old-wordkaround-windows-syntax is no more necessary on windows, and that we can now use the standard linux syntax.

Thanks, and sorry for the inconvenience.

oupala commented 8 years ago

In fact, #7 does not work.