christophergandrud / imfr

R package for interacting with the IMF RESTful JSON API
47 stars 5 forks source link

Fix/imf ids #14

Closed mitsuoxv closed 4 years ago

mitsuoxv commented 5 years ago

After #11 was resolved, the output of the function imf_ids does not include even "IFS". I have checked http://datahelp.imf.org/knowledgebase/articles/667681-using-json-restful-web-service, and found http://dataservices.imf.org/REST/SDMX_JSON.svc/Dataflow (note: I have removed the last /) returns something. From that, I have managed to extract database_id and description.

cjyetman commented 5 years ago

It's probably not ideal to import stringr just for str_sub and str_replace, and purrr just for map_chr. I would suggest re-writing those in base R to avoid adding new dependencies for the package.

mitsuoxv commented 5 years ago

I have found "?format=sdmx-json" works. I have modified to avoid adding new dependencies.