search

christophergandrud / networkD3

D3 JavaScript Network Graphs from R
http://christophergandrud.github.io/networkD3
652 stars 268 forks source link

D3v4 minimal conversion #167

Closed cjyetman closed 7 years ago

cjyetman commented 7 years ago

resolves issue #143

This is the pull request implements the minimal conversion to D3v4.

The primary goal was to achieve the conversion to D3v4 with the absolute minimum changes. That means some things are still not ideal, but this should be the easiest path to a full package conversion to D3v4. Other improvements and changes can/will occur afterwards (based on my discussions with @christophergandrud).

christophergandrud commented 7 years ago

Really sorry about the delay (I was doing a ton of traveling the last couple of days).

From what I tested it looks Great! Thanks so much for all of your hard work on this!

Before I push it to CRAN, could you check the contributors in the DESC to see if your name is how you'ld like it and also the NEWS to see if v0.3 has an adequate description?

Thanks again!

cjyetman commented 7 years ago

both look good to me... thanks! 👍