search

christophergandrud / networkD3

D3 JavaScript Network Graphs from R
http://christophergandrud.github.io/networkD3
649 stars 269 forks source link

make simpleNetwork an alias of forceNetwork #181

Closed cjyetman closed 7 years ago

cjyetman commented 7 years ago

This PR removes the simpleNetwork JavaScript code, and converts the simpleNetwork() R function to be an alias of forceNetwork(). This simplifies maintenance by unifying the two functions and using one common underlying JavaScript file. This should be seen as a soft-deprecation of simpleNetwork(), whereas we maintain the function and maintain (mostly) its functionality for backward compatibility's sake, but it is now simply a convenience wrapper for forceNetwork(). We should consider enabling forceNetwork() to accept a simple data frame as simpleNetwork() does, thereby completely eliminating the need for simpleNetwork().

This PR resolves issue #170

cjyetman commented 7 years ago

important note

this removes and disables the following two arguments due to incompatibility with forceNetwork():

we should probably note this in News.md for the release