search

christophergandrud / networkD3

D3 JavaScript Network Graphs from R
http://christophergandrud.github.io/networkD3
652 stars 268 forks source link

dendroNetwork linkColour option is not working #255

Closed teshomem closed 5 years ago

teshomem commented 5 years ago

Hi,

hc <- hclust(dist(USArrests), "ave") dendroNetwork(hc, height = 600, linkType = 'elbow', linkColour = 'red')

Thanks

cjyetman commented 5 years ago

confirmed. Thanks for the report and reproducible example.

This was fixed in diagonalNetwork and radialNetwork with #107, but dendroNetwork was missed.

https://github.com/christophergandrud/networkD3/blob/master/inst/htmlwidgets/dendroNetwork.js#L107 should be changed from

      .style("stroke", "#ccc")

to

     .style("stroke", x.options.linkColour)
teshomem commented 5 years ago

Thanks, how quickly can it be fixed?

cjyetman commented 5 years ago

That's dependent on the people who are willing, and have the necessary skill and knowledge to volunteer their time to do so.

teshomem commented 5 years ago

OK, thanks. This fix is not difficult. If i make the changes in my own branch, will you allow me to push it to your repo so that i will make the PR?

cjyetman commented 5 years ago

Yes, you may make a PR. Once a maintainer merges it, it will be available if you install the dev version of the package from Github. Getting it rolled into a release version submitted to CRAN is another story though.

teshomem commented 5 years ago

Thank you so much for the help.