christopherjwhite / org-toodledo

Emacs enhancement for syncing org-mode tasks with Toodledlo
83 stars 16 forks source link

Unable to synchronize all completed todo on the Toodledo server. #26

Closed lawlist closed 10 years ago

lawlist commented 10 years ago

The most recent two versions of org-toodledo.el do not appear to have the ability to synchronize all completed todo on the Toodledo server. I reverted back to version 2.11 in order to re-enable that behavior.

If a user has completed tasks on the Toodledo server and a blank org file, then none of the completed tasks will synchronize to the org file using a current version of org-toodledo.el. Only after the org file has been synchronized with the Toodledo server, will subsequently completed tasks on Toodledo synchronize back to the org file. The tasks that were completed prior to the first synchronization with the org file will not synchronize to the org file.

christopherjwhite commented 10 years ago

Did you try setting org-toodledo-sync-new-completed-tasks to t? This defaults to nil. However, it's been there since long before 2.10, so I'm not sure why it would work in 2.10 and not in newer releases...

...cj

On 9/22/13 3:37 PM, lawlist wrote:

The recent versions of |org-toodledo.el| do not appear to have the ability to synchronize |all| completed todo on the Toodledo server. I reverted back to version 2.10 in order to re-enable that behavior.

If a user has completed tasks on the Toodledo server and a |blank| org file, then none of the completed tasks will synchronize to the org file using a current version of |org-toodledo.el|. Only after the org file has been synchronized with the Toodledo server, will subsequently completed tasks on Toodledo synchronize back to the org file. The tasks that were completed prior to the first synchronization with the org file will |not| synchronize to the org file.

— Reply to this email directly or view it on GitHub https://github.com/christopherjwhite/org-toodledo/issues/26.

lawlist commented 10 years ago

It is line 993:

(alist-put params "comp" (if init "0" "-1"))

Instead of:

(alist-put params "comp" "-1")

Some users may prefer that their org file match the server exactly -- i.e., all tasks whether completed or not. With line 993 the way it is now (if init "0" "-1"), users cannot have org-toodledo-sync populate a blank org file with everything on the server. If users wish to exclude completed tasks, either on the initial or subsequent synchronization, perhaps this could be a user defined variable -- otherwise, source code modification by the user would be required.

christopherjwhite commented 10 years ago

Got it, I changed this to:

(alist-put params "comp" (if (or init org-toodledo-sync-new-completed-tasks) "0" "-1"))

Will check in with other fixes / changes.

christopherjwhite commented 10 years ago

My comment above was incorrect -- the correct fix is:

(alist-put params "comp" (if (and init (not org-toodledo-sync-new-completed-tasks)) "0" "-1"))

Committed.