search

christopherkade / banner-generator

:speech_balloon: Easily generate banners for your articles on dev.to
https://christopherkade.com/banner-generator/
MIT License
63 stars 9 forks source link

Rich-text editing support #1

Closed briwa closed 2 years ago

briwa commented 5 years ago

Hey, I came across this on dev.to. I think the idea is brilliant, I never knew I would have needed this because I always steal photos from Unsplash for the image banner.

I have a suggestion tho. How about rich-text feature? This allows them to maybe edit the text on the banner itself instead of the input box while allowing the text to be bolded/italic/etc. Libraries like draft.js or slate.js could accomplish this. And if it's not anything fancy, I think html2canvas could still render them as images (this one I might need to test).

What do you think? Is this something you have in mind too? If it is, let me know. I am interested to work on this if you don't mind (this is because I want to validate this idea too, it might not work 😂). Thanks.

christopherkade commented 5 years ago

That's a great idea @briwa ! That would allow a greater customisation of the banner's content.

We do need to make sure that it won't cause of problem with html2canvas, as each CSS property is implemented by hand (more info).

If you'd like to take the lead on that one, go ahead, but make sure to read up on the contribution guidelines first.

Thank you ! 😄