search

christopherkade / banner-generator

:speech_balloon: Easily generate banners for your articles on dev.to
https://christopherkade.com/banner-generator/
MIT License
63 stars 9 forks source link

Option to change the border's color #10

Closed christopherkade closed 5 years ago

christopherkade commented 5 years ago

If the user clicks on the border option, display a color picker to modify its color.

diveresque commented 5 years ago

Hi are you still looking for some help with this? I could give it a try :)

christopherkade commented 5 years ago

Hello @diveresque ! Absolutely, thanks for your interest.

If you need any help feel free to ask, otherwise you can always check out the guidelines.

diveresque commented 5 years ago

Hi @christopherkade I made the changes (just locally so far) but I wasnt able to get the gitmoji thing happening.. I followed the directions on https://github.com/carloscuesta/gitmoji-cli for commit-hook (to be honest im not sure what that means); after I did a normal git add and commit, I was expecting some other prompt for gitmoji, but nothing appeared.. could you explain how to do it? Thanks!

christopherkade commented 5 years ago

Awesome, can't sait to see your work :)

The commit hook basically means it will catch any commits you make and display the prompt (which will allow you to write the commit's title, description, issue number etc.), it's nothing more than that.

Following the hook section should make everything work (as it has for me up until now, just make sure to install gitmoji-cli globally).

diveresque commented 5 years ago

Hm ok.. Im quite sure I installed it globally, just followed the directions: npm i -g gitmoji-cli

I did get an error when running gitmoji -i

gitmoji_error ..but I assumed it was ok because it said 'successful' at the end.. maybe it wasnt actually successful??Have you seen this error message before?

diveresque commented 5 years ago

Ok this is fixed now, something to do with gpg :) but i just realised I didnt create a separate branch for the changes 🤕 will work on this again tomorrow :)

diveresque commented 5 years ago

Let me know if you have any feedback about it, including the contributing process :)