christopherkade / banner-generator

:speech_balloon: Easily generate banners for your articles on dev.to

https://christopherkade.com/banner-generator/

MIT License

63 stars 9 forks source link

Closed diveresque closed 5 years ago

diveresque commented 5 years ago

10 - Add a border color picker

christopherkade commented 5 years ago

Great work, just a couple of notes:

Make sure the PR status is set to "passed" (you can see why yours is not passing here, hint: it's linked to your snapshots, you need to run yarn test -u to update them)
It's a bit odd to see the color picker if the "border" option is not ticked. I have an idea to solve that problem, I'll replace the checkbox by a border size input, 0 being invisible. This way it's not as weird to have a color picker.

diveresque commented 5 years ago

Yes it had crossed my mind about that second point re the border option, that sounds like a good solution.

christopherkade commented 5 years ago

Great job, thank you @diveresque