search

christopherkade / banner-generator

:speech_balloon: Easily generate banners for your articles on dev.to
https://christopherkade.com/banner-generator/
MIT License
63 stars 9 forks source link

:sparkles: Add option to upload background image #15

Open diveresque opened 5 years ago

diveresque commented 5 years ago

Using react-dropzone and FileReader to allow user to upload image from computer onto background-image of the banner #5

diveresque commented 5 years ago

Hi @christopherkade have done the basics for upload images, needs a bit of tweaking, but thought its good to get some feedback at this point.

Also the checks didnt work as you can see - the error says to run yarn add react-dropzone, is that correct?

christopherkade commented 5 years ago

This is awesome work, I've been fiddling around with it and you did a great job.
Make sure to remove package-lock.json, we already have a yarn.lock 😄

I've done a code review, most of these changes are tiny so don't worry if you see so many comments !

diveresque commented 5 years ago

Thanks for the feedback, I am going through these. Im happy about the many comments, its good to learn! :D