search

christopherkade / banner-generator

:speech_balloon: Easily generate banners for your articles on dev.to
https://christopherkade.com/banner-generator/
MIT License
63 stars 9 forks source link

added border color #4

Closed malithmcr closed 5 years ago

malithmcr commented 5 years ago

hey @christopherkade could you check this pr please?

christopherkade commented 5 years ago

Hi, I'm checking PRs whenever I have the time :)

Anyways thank you for your contribution, just a few notes:

Issues have now been opened for requested features, so don't hesitate to ask & be assigned if you want to work on something specific.

malithmcr commented 5 years ago

Hi, I'm checking PRs whenever I have the time :)

Anyways thank you for your contribution, just a few notes:

  • Shouldn't the "border color" option appear only when the "border" option is set to true?
  • Make sure to be up to date with the master branch as a few changes have been made to both the structure and display of the project
  • Also make sure the project's status is set to "passed" so I can merge your work 😄

Issues have now been opened for requested features, so don't hesitate to ask & be assigned if you want to work on something specific.

Awesome! thanks for taking the time to check the PR. I will do the changes and create a new PR.