search

christopherkade / banner-generator

:speech_balloon: Easily generate banners for your articles on dev.to
https://christopherkade.com/banner-generator/
MIT License
63 stars 9 forks source link

Download banner as jpeg #8

Closed nicolus closed 5 years ago

nicolus commented 5 years ago

The types allowed by toDataUrl are image/png and image/jpeg. Using image/jpg would make the browser fallback to image/png and result in a .jpg file that was actually a png.

That said, a png file is probably better in most cases, so we might be better off using image/png and renaming the file to banner.png

christopherkade commented 5 years ago

Let's go for png files then. Could you please change it so I can merge your work?

Make sure to be up to date with master as I did some tweaks to fix a bug.

Thank you !

christopherkade commented 5 years ago

Hello, I took the liberty of doing it in the following commit: https://github.com/christopherkade/banner-generator/commit/3d76e812f99a7c29feddbbd327a5cb1cc816d5da.