search

christopherpow / nesicide

Integrated Development Environment for the 8-bit Nintendo Entertainment System
315 stars 38 forks source link

converts windows path separators #1

Closed hyarion closed 11 years ago

hyarion commented 11 years ago

converts windows path separators ('\') used in #include directive to unix compatible path separators ('/')

christopherpow commented 11 years ago

Thanks hyarion! I knew there'd be cross-platform problems because I haven't yet had a chance to try compiling it or my MFC HLE on anything but Windows. I know there's at least one or two APIs that FamiTracker's still using still that are Windows-only [GetSysColor, ...] because I haven't put thought to their Qt replacement yet.

I'll pull your merge tonight...can't do it now I'm at work.

Thanks for your help!

On Tue, Feb 12, 2013 at 5:58 AM, Benjamin Eriksson <notifications@github.com

wrote:

converts windows path separators ('\') used in #include directive to unix

compatible path separators ('/')

You can merge this Pull Request by running

git pull https://github.com/hyarion/nesicide xplatform

Or view, comment on, or merge it at:

https://github.com/christopherpow/nesicide/pull/1 Commit Summary

  • converts windows path separators

File Changes

  • M libs/famitracker/APU/Mixer.hhttps://github.com/christopherpow/nesicide/pull/1/files#diff-0(4)

Patch Links:

hyarion commented 11 years ago

Your welcome! As you can see I added a new commit which re-implements some windows specific datatypes, I should work, but since (at least) one file is still missing ( FamiTrackerView.h ) I couldn't compile the rest of the project.

christopherpow commented 11 years ago

That file should be there now...? git doesn't show me as not having added it. Let me know.

I am working on integrating the SoundGen thread so I can have this thing animate and...eventually...play! =]

Note: it's nowhere near done, but major portions of functionality are working. I haven't integrated any of the config dialogs or the instrument editors yet. But the frame editor and pattern editor are working mostly nicely together.

I'm excited to get this working on OSX! I also am hoping to refresh my Ubuntu VM and try it there...but I am stuck in "dev" mode for the moment on Windows! =]

Hope all is well with you!

On Tue, Feb 12, 2013 at 8:10 AM, Benjamin Eriksson <notifications@github.com

wrote:

Your welcome! As you can see I added a new commit which re-implements some windows specific datatypes, I should work, but since (at least) one file is still missing ( FamiTrackerView.h ) I couldn't compile the rest of the project.

— Reply to this email directly or view it on GitHubhttps://github.com/christopherpow/nesicide/pull/1#issuecomment-13433863.