christopherpow / nesicide

Integrated Development Environment for the 8-bit Nintendo Entertainment System

315 stars 38 forks source link

Problems with QVariant and some undefined functions on Linux... #12

Closed Jarhmander closed 10 years ago

Jarhmander commented 10 years ago

Fixes for libfamitracker and nesicide

2 small changes here:

QVariant has ctor overloads for int, unsigned int, qlonglong (long long int) and qulonglong (unsigned long long int), but no unsigned long int overload. As a result, (implicit) calls to QVariant ctor with UINT_PTR arguments are ambiguous. Fix: those problematic implicit ctor calls cast the UINT_PTR value to uint_ptr, a typedef hidden in a namespace qtmfc_workaround; uint_ptr is unsigned int or qulonglong depending on the size of UINT_PTR;
Commented-out calls to ShellExecute and TrackMouseEvent: they are currently undefined.

christopherpow commented 10 years ago

Closed?

Jarhmander commented 10 years ago

I've rebased my branch onto your master and I wanted to cancel my pull request. I don't know if it's necessary if I update my branch, but to avoid any confusion, I did that. Wasn't expecting such "noise" for such action ;). I forgot to add last time that for the QVariant problem, I wrote a (portable and easy) fix, but there really is more than one way to skin a cat.

― James-Adam Renquinha Henri

On Mon, Apr 7, 2014 at 12:14 PM, Christopher Pow notifications@github.comwrote:

Closed?

— Reply to this email directly or view it on GitHubhttps://github.com/christopherpow/nesicide/pull/12#issuecomment-39750400 .

christopherpow commented 10 years ago

Not noise. Just curious. I had planned to implement ShellExecute and the other missing API but got distracted this weekend.

On Mon, Apr 7, 2014 at 11:20 AM, Jarhmander notifications@github.comwrote:

I've rebased my branch onto your master and I wanted to cancel my pull request. I don't know if it's necessary if I update my branch, but to avoid any confusion, I did that. Wasn't expecting such "noise" for such action ;). I forgot to add last time that for the QVariant problem, I wrote a (portable and easy) fix, but there really is more than one way to skin a cat.

James-Adam Renquinha Henri

On Mon, Apr 7, 2014 at 12:14 PM, Christopher Pow notifications@github.comwrote:

Closed?

Reply to this email directly or view it on GitHub< https://github.com/christopherpow/nesicide/pull/12#issuecomment-39750400> .

Reply to this email directly or view it on GitHubhttps://github.com/christopherpow/nesicide/pull/12#issuecomment-39751059 .

Jarhmander commented 10 years ago

My apologies; by noise I meant "Christopher Pow receives notification for closed pull request". I'll soon just reissue this pull request with my updated (rebased) branch.

EDIT: Ahah, GitHub is still seeing the old commit even if I updated the branch, I see it undoing things on master unrelated to my changes. New pull request.

christopherpow commented 10 years ago

Haven't forgotten this. Just got back to trying to build in Linux now. Many many changes in the last couple days. I am getting nearer to a FamiTracker release...hopefully very soon! I will likely cherry pick parts of your pull request since I've added stubs for the missing functions.

On Mon, Apr 7, 2014 at 1:46 PM, Jarhmander notifications@github.com wrote:

Reopened #12 https://github.com/christopherpow/nesicide/pull/12.

Reply to this email directly or view it on GitHubhttps://github.com/christopherpow/nesicide/pull/12 .