christopherpow / nesicide

Integrated Development Environment for the 8-bit Nintendo Entertainment System
315 stars 38 forks source link

Renamed CHAR_WIDTH to CHARACTER_WIDTH #23

Closed CuriouslyCurious closed 6 years ago

CuriouslyCurious commented 6 years ago

This is the only change code-wise that needed to be done to make the whole project compile both on my Arch-Linux laptop and desktop.

I'm guessing the reason why this variable needs to be renamed is because something in boost or another dependency is defined as CHAR_WIDTH and when the compiler tries to compile PatternEditor.cpp it gets confused and refuses to continue, so I just renamed the variable to CHARACTER_WIDTH and everything worked flawlessly.

christopherpow commented 6 years ago

Excellent! Thanks for the help. I'll merge as soon as Travis completes, assuming Travis likes it.