search

christopherpow / nesicide

Integrated Development Environment for the 8-bit Nintendo Entertainment System
315 stars 38 forks source link

Updates QActions to conform to actual constructor. #26

Closed jcordial closed 6 years ago

jcordial commented 6 years ago

In trying to get this to build on OSX 10.12.6, I had to make these modifications. According to the docs (http://doc.qt.io/archives/qt-5.6/qaction.html), I'm not sure how this was building previously, given that the constructor signature doesn't match your instantiation.

This will likely need to be modified, as I don't usually use Qt, so I just threw code at the problem till it built.

christopherpow commented 6 years ago

The QAction constructor in 5.9 has a default value for the parent parameter which is why it compiles for me. I'm now using 5.9, and the recent files list was added very recently. I'll add 5.6 kit and build with that before accepting this PR.

jcordial commented 6 years ago

@christopherpow You might want to update the Readme then. It still says to use the 5.6 kit. Thanks for building this!