search

christopherpow / nesicide

Integrated Development Environment for the 8-bit Nintendo Entertainment System
316 stars 38 forks source link

Fix missing hex-decode in rc2qt.py #42

Closed nyanpasu64 closed 5 years ago

nyanpasu64 commented 5 years ago

You also have a bunch of trailing whitespace which I didn't remove in this PR.

Maybe you should call rc2qt as a build step, or in CI, to make sure it's up-to-date, and visualize exactly what has changed. I'm not experienced with implementing automated differential testing though.

nyanpasu64 commented 5 years ago

oops my code is broken... and you didn't check to see if it's correct...

-       mfc27->AddString(_T("667831"));
+       mfc27->AddString(_T("b'fx1'"));

I'm doing some manual differential testing and rebasing/etc. on my local branch, making sure to regenerate and commit libs/famitracker/cqtmfc_famitracker.cpp every time I change tools/rc2qt/rc2qt.py.

christopherpow commented 5 years ago

Ok let me know when you fix it...for real.

It looked like such a small change. And like I said, I haven't had a need for rc2qt yet. It LOOKED right. :)

I'm happy someone's actually using it.

On Fri, Jun 21, 2019 at 10:53 PM jimbo1qaz notifications@github.com wrote:

oops my code is broken... and you didn't check to see if it's correct...

  • mfc27->AddString(_T("667831"));+ mfc27->AddString(_T("b'fx1'"));

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/christopherpow/nesicide/pull/42?email_source=notifications&email_token=AAMQR4FM2HZDLB6AKFS5Y4LP3WO3ZA5CNFSM4H2V4ZMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJ7PLI#issuecomment-504625069, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMQR4H7AC5BVRCBWM7MXJTP3WO3ZANCNFSM4H2V4ZMA .