search

christopherpow / nesicide

Integrated Development Environment for the 8-bit Nintendo Entertainment System
316 stars 38 forks source link

Fix rc2qt hex decoding, remove Python-style b'' from C++ output #43

Open nyanpasu64 opened 5 years ago

nyanpasu64 commented 5 years ago

The resulting cqtmfc_famitracker.cpp is identical to the outdated version from master.

nyanpasu64 commented 5 years ago

I have a script to regenerate cqtmfc_famitracker.cpp:

#!/bin/sh
cd $(git rev-parse --show-toplevel)

python tools/rc2qt/rc2qt.py \
       libs/famitracker/FamiTracker.rc \
       > libs/famitracker/cqtmfc_famitracker.cpp

Should I add this to master? I'm currently using my own version (adapted for j0cc) on my unfinished j0cc branch.

christopherpow commented 5 years ago

Yes, please merge that script.

nyanpasu64 commented 5 years ago

pushed again? the presence of the broken script in master makes me uncomfortable.

christopherpow commented 5 years ago

What broken script?

nyanpasu64 commented 5 years ago

the .py in master is broken and produces incorrect output.

christopherpow commented 5 years ago

Fixed.

On Thu, Jun 27, 2019 at 11:22 AM jimbo1qaz notifications@github.com wrote:

the .py in master is broken and produces incorrect output.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/christopherpow/nesicide/pull/43?email_source=notifications&email_token=AAMQR4A34XJ2IA3UHZ5S5LLP4TSNJA5CNFSM4H2V7A72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXUX7Y#issuecomment-506416127, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMQR4AACVYCL22BUXFIXFTP4TSNJANCNFSM4H2V7A7Q .