search

christopherreay / thisEqualsThat_frontEnd

Online, collaborative pipeline for visualising information
GNU General Public License v3.0
6 stars 5 forks source link

pull request for new UI #72

Closed bertonbeil closed 7 years ago

bertonbeil commented 7 years ago

Hope this is correct pull request, if not please fix me

christopherreay commented 7 years ago

looks good. I'll have a look to resolve it in the morning x thanks

bertonbeil commented 7 years ago

good night, thank you too

2017-02-20 22:48 GMT+02:00 Christopher notifications@github.com:

looks good. I'll have a look to resolve it in the morning x thanks

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/christopherreay/thisEqualsThat_frontEnd/pull/72#issuecomment-281178052, or mute the thread https://github.com/notifications/unsubscribe-auth/AKZH2CxC4gCjOO0LCn9FUEBbhPG-umwsks5refwVgaJpZM4MGljm .

christopherreay commented 7 years ago

OK. Ive merged the pull request. Its looking pretty good. The conflicts were all pretty obvious and simple.

Ive put the merged version up on dev.visualtools.org

There are two clear issues that I can see. One I can fix, but the other I would like you to fix.

If you can see on the production, there is an animation which shows when the calculation is waiting for the server, and a different animation when the calculation is rendering the SVG representation. This is managed very easily by a css class which is attached to the elements which animate.

Could you find out where that is, and put the css class back?

This is a good thing for you to see in the code.

The second issue is the CSS layout of the toggle classes you have placed over the top of the controls. This should be easy to resolve as well

christopherreay commented 7 years ago

Im making the toggleFeatures into an SVGHUD plugin, which makes sense, and means they will be in the right place. Amazingly enough.

I used css to fix it, but this is the right solution