search

christopherreay / thisEqualsThat_frontEnd

Online, collaborative pipeline for visualising information
GNU General Public License v3.0
6 stars 5 forks source link

Optimize markup structure #81

Open bertonbeil opened 7 years ago

bertonbeil commented 7 years ago

In markup are many unnecessary tags and attachments

just have a look on this screen(markup Constructs button): image

first of all, it's definitely invalid markup

it should look like this, this one definitely look like better

<a href="#" class=" createConstruct row" data-toggle="modal" data-target=".constructBlueprint">
  <i class="material-icons">view_comfy</i>
  <span>Construct</span>
</a>
christopherreay commented 7 years ago

well I don't know. the point is that those "extra"tags are what bootstrap uses to make everything work. that's what I thought anyway

bertonbeil commented 7 years ago

@christopherreay I'm sorry, you make all correct but "using bootstrap = always valid markup" wrong

I will explore it and try to make it valid, as it possible )

christopherreay commented 7 years ago

what you have said isn't logical. but go ahead. I have no commitment to the markup. it works

christopherreay commented 7 years ago

bootstrap uses the markup. we're not using bootstrap to make the markup