christophertbrown / iRep

scripts for estimating bacteria replication rates based on population genome copy number variation
MIT License
68 stars 9 forks source link

potential issue with np.arange(100,1000,10000) bPTR line 223 #42

Open mariaelf97 opened 1 year ago

mariaelf97 commented 1 year ago

Dear Chris,

Good day to you. I am trying to implement a few parts of your code on my data and I noticed an issue with the estimate_pars() function. in line 223 of your code, you're passing np.arange(100,1000,10000) to signal.find_peaks_cwt function as width. np.arange(100,1000,10000) however, returns to a single value (100). I wonder if the order is wrong and you wanted to specify it as np.arange(100,10000,1000)?