SLURM exporting all variables instead of selected ones

christopherwharrop / rocoto

Rocoto Workflow Management System

Apache License 2.0

21 stars 16 forks source link

SLURM exporting all variables instead of selected ones #39

Closed samtrahan closed 5 years ago

samtrahan commented 5 years ago

In SLURM, by default, all environment variables are exported to the job, leading to a variety of confusing errors. The change in branch bugfix/slurm-no-default-export uses --export=NONE to disable default exporting. That way, only the ones in <envar> blocks are exported.

This fix is being tested now. We hope to have test results by the end of the day.

christopherwharrop commented 5 years ago

Thank you for finding and diagnosing this, and for testing a fix. A quick reminder: bug fixes should be done in "bugfix" branches, not "feature" branches.

samtrahan commented 5 years ago

The branch has been renamed.

samtrahan commented 5 years ago

Terry has reported back that the fix worked, so I'm going to do a pull request for this shortly...

christopherwharrop commented 5 years ago

This was fixed in PR #41 . Closing.