christopherwharrop / rocoto

Rocoto Workflow Management System
Apache License 2.0
20 stars 16 forks source link

Fix /bin/sh incompatibilities in INSTALL script #93

Closed christopherwharrop-noaa closed 3 years ago

christopherwharrop-noaa commented 3 years ago

The INSTALL script contains several lines of code that are broken in Bourne shell due to use of == instead of = in string comparisons. This has gone unnoticed because this code was developed and tested on systems which link /bin/sh to /bin/bash. The INSTALL script also contains several uses of backtics where a subshell expression would be more appropriate and standard practice. This PR fixes these errors, resulting in a script that works correctly for both /bin/sh and /bin/bash shells.