search

christopherwharrop / rocoto

Rocoto Workflow Management System
Apache License 2.0
20 stars 16 forks source link

fix typo: core_signal => code_signal #97

Closed SamuelTrahanNOAA closed 1 year ago

SamuelTrahanNOAA commented 1 year ago

Fixes #96 wherein a typo in slurmbatchsystem.rb breaks support for 0:0 style return codes.

  code_signal=job[230..239].strip
  if code_signal=~ /:/
    code,signal=core_signal.split(":").collect {|i| i.to_i}

The last line has core_signal but the variable's name is code_signal.

This is a draft because I'm waiting for @natalie-perlin to test it. Once she confirms, we'll know it fixes #96

natalie-perlin commented 1 year ago

@SamuelTrahanNOAA - Thank you for suggesting a quick fix and a solution! 🙏🏼 👍🏼 Few Qs to clarify on how should I test it -

Does it apply to all the versions? I've built 1.3.3 and 1.3.5 (just because they were used in the past). Do I need to make a patch/correction for 1.3.3 and/or 1.3.5 to test it? Should I test it with the develop branch as well?

SamuelTrahanNOAA commented 1 year ago

You should use my branch from this PR:

git clone --branch code-not-core https://github.com/SamuelTrahanNOAA/rocoto
natalie-perlin commented 1 year ago

All works well with the fix. Clone the repo clone --branch code-not-core https://github.com/SamuelTrahanNOAA/rocoto, build it as a new module. Status of running jobs shows up as "RUNNING", as expected.

SamuelTrahanNOAA commented 1 year ago

@christopherwharrop - I think this means you can merge it now.