search

christophesmet / android_maskable_layout

A library that easily allows you to mask layouts/viewgroups
Apache License 2.0
652 stars 145 forks source link

Cropping map fragment removes more than needed #45

Closed GeorgeMincila closed 3 years ago

GeorgeMincila commented 4 years ago

Hi,

Found your project looking for something to crop my Google map to a rounded corners shape. Nothing worked so far. I tried yours and it seems to remove too much. Somehow all the map content is removed, while the minimal Google Map UI can notice is cropped off to the shape I used.

Left side using the maskablelayout, right side plain map fragment. https://drive.google.com/file/d/16aivbVtTkgFm7eOSF6BWaYlagUwTkFO/view?usp=sharing

Any idea what is happening and why the entire map layer is disappearing?

Thanks.

christophesmet commented 4 years ago

Hey George, I cant see the image but I assume the google maps view is completely black.

Chances are high that the porterduff mode you are using only supports software rendering, and since google maps is highly optimized I wouldn't be surprised if it was rendered with hardware acceleration.

Setting the layer to software will probably not be a solution. You can apply masking and other effects using shaders, but this library only supports software layers, not hardware.

Some modes should work like PorterDuff.Mode.SRC_IN in hardware layers. I would suggest trying it with hardware supported modes, else you will have to use shaders.

GeorgeMincila commented 4 years ago

Appreciate the quick reply. I tried the SRC_IN mode. I am getting the same result. Can click the image url again. I made sure it is public.

Will have to get informed about shaders. I don't know how to use them yet.

christophesmet commented 4 years ago

Romain guy had some great info about this subject. His blog seems to be offline: https://web.archive.org/web/20140318001921/http://www.curious-creature.org/2012/12/11/android-recipe-1-image-with-rounded-corners/ Anyway, I'm gonna close this as it only supports software layers and I think the hardware rendering of google maps is the problem. I suggest adding a background to the google maps container instead of making it 'float'. Then you can overlay rounded corners. Its not as clean tho. If you found a way, I'd love to hear the solution. Good luck!