[upd] Add a zero-volume indication

christophgysin / pasystray

PulseAudio system tray

GNU Lesser General Public License v2.1

448 stars 43 forks source link

[upd] Add a zero-volume indication #150

Closed YanDoroshenko closed 2 years ago

YanDoroshenko commented 3 years ago

Not sure this can be merged as is. audio-volume-zero-symbolic.svg is not included in every icon theme and if it is absent, a placeholder for a missing icon (like a broken image frame) is displayed. Maybe it should be enabled with a feature flag or something?

christophgysin commented 3 years ago

audio-volume-zero-symbolic.svg is not included in every icon theme

Is there a way to check and dynamically fall back to another icon? If so, I'd be happy to merge this.

YanDoroshenko commented 3 years ago

How does this look? I've restructured fallbacks so that:

a volume level uses the next one as a fallback
a mic level uses the next mic level as a fallback and if it's out of mic levels, it tries to use the relevant volume level (with volume level fallbacks)

YanDoroshenko commented 3 years ago

@christophgysin What do you think?