Lost icon after upgrade to 0.8.0-1

sbbddz commented 3 years ago

Hi, today I noticed that after updating my system (running Arch Linux with dwm as my window manager) pasystray icon disappear from my system tray.

Here is the before and the after: before_update_pasystray >>> after_update_pasystray Icon however, still works and its clickable. Haven't tested it in another desktop environment or window manager. Still possible to be some kind of issue with my setup, I'll continue researching.

Version not working: 0.8.0-1 Arch Linux with dwm as window manager Version working: 0.7.1

Thanks for your attention!

stm28304 commented 3 years ago

Same here. I use arch also; but openbox.

kofm commented 3 years ago

Hi, today I noticed that after updating my system (running Arch Linux with dwm as my window manager) pasystray icon disappear from my system tray.

Here is the before and the after: >>> Icon however, still works and its clickable. Haven't tested it in another desktop environment or window manager. Still possible to be some kind of issue with my setup, I'll continue researching.

Version not working: 0.8.0-1 Arch Linux with dwm as window manager Version working: 0.7.1

Thanks for your attention!

Exactly the same for me, tried changing icon theme but it always pick up light version

aimixess commented 3 years ago

Hi,

Same problem here with awesomewm 2021-11-10-123422_45x28_scrot . I also launch it with -t option but the tooltip is still appearing. 2021-11-10-123946_127x39_scrot

cyberpunkrocker-zero commented 3 years ago

Same issue here. On my Arch desktop (Awesome), the icon turned black, which is a very bad idea, because I'm using very dark grey as a systray background. On my Arch laptop (i3), the icon turned white.

I'm going to stick with pasystray-0.7.1 until this is fixed...

What was the big idea behind the change, anyway?

christophgysin commented 3 years ago

Can you check if this is caused by using symbolic icons? E.g. by commenting out the lines: https://github.com/christophgysin/pasystray/blob/master/src/ui.c#L155-L158

aimixess commented 3 years ago

Hi,

I tried and have the white icon back 2021-11-11-221638_52x28_scrot .

It also solve the problem I had with -t switch but not in the right way : tootltip is not working with or without.

arash-rohani commented 3 years ago

Can you check if this is caused by using symbolic icons? E.g. by commenting out the lines: https://github.com/christophgysin/pasystray/blob/master/src/ui.c#L155-L158

That fixed the color issue for me as well.

sbbddz commented 3 years ago

Works for me after removing the code lines mentioned earlier!

christophgysin commented 3 years ago

Could someone test if PR #153 fixes it? It should use the standard icons by default, and only use the symbolic ones when started with --symbolic-icons.

aimixess commented 3 years ago

Could someone test if PR #153 fixes it? It should use the standard icons by default, and only use the symbolic ones when started with --symbolic-icons.

I just pull symbolic-icons branch and compile again and icon is still white, it seems to work. Symbolic icons appear if I put the --symbolic-icons switch.

arash-rohani commented 3 years ago

The branch works correctly. But I just realized something. The problem with symbolic icon appearing as black even though we are using a dark theme is panel specific. Because I was not using another systray application that uses symbolic icons I never noticed that. For example "tint2" panel doesn't respect the dark theme when using symbolic icons but when I tested the exact same thing for "xfce4-panel" and "i3bar" they show the white symbolic icons. If @christophgysin wants to make symbolic icons the default from now on, as long there's an option to opt out (like --no-symbolic-icons) it should be fine. Either way works.

cyberpunkrocker-zero commented 3 years ago

IMHO no program should ever force users to use symbolic icons, there should always be an option.