christophhart / HISE

The open source framework for sample based instruments
http://hise.audio
Other
1.07k stars 123 forks source link

[Cosmetic] Fine-tune on slider glitching out #433

Open aaronventure opened 1 year ago

aaronventure commented 1 year ago
  1. Hold fine-tune modifier and change the value of the slider. Can be default graphic, can be custom LAF.
  2. While moving the mouse, let the modifier key go and continue moving the mouse.

The control will, for a seemingly single frame, jump to the max or min value depending on direction. If you time it just right, letting go of the mouse click will actually result in the control being set to min/max.

The gif example is 60fps but my screen is 175hz, so some occurances might not have been captured. However, many have, and I end the capture by timing the click release, resulting in the value jumping to the maximum. This shouldn't happen, because in cases where the glitch doesn't happen, you can clearly see that the speed-up when the modifier is no longer pressed isn't crazy.

hise finetune glitch

While not exactly game-breaking, this does make for a rather ugly experience and the product might seem unprofessional.

It happens for default graphic, LAF, default fine-tune mapping and the custom finetune mapping (with newly-added setModifier option).

Win11, 714952fef9a44540d42726624015fd9ca7453940

aaronventure commented 1 year ago

I have now noticed that the mouse cursor jumps for a frame as well, and then returns to the correct position, so the value jump is likely due to the cursor being overshot by whatever function sets it to its new position (I assume it's the same one that makes it disappear when the fine-tune mode is enabled).

aaronventure commented 1 year ago

I can't reproduce this in the built VST3 on Win11. No glitch. So that's good.

If you can reproduce this in HISE on Mac, can you check in a built plugin?