search

christophhart / HISE

The open source framework for sample based instruments
http://hise.audio
Other
1.04k stars 122 forks source link

Token Select via CTRL+D Doesn't Match Selection Highlight #455

Closed aaronventure closed 5 months ago

aaronventure commented 10 months ago

CTRL+D selection doesn't match the displayed highlighted matches for selected tokens.

Highlights are only for complete tokens, while CTRL+D will select partial as well.

hise highlight

christoph-hart commented 10 months ago

Hmm, there's a mismatch between how Sublime and VS handles this so the world hasn't reached a verdict here and I picked the Sublime one:

Sublime:

sub

VS:

sub2

HISE:

sub3

I find the current implementation more practical for my workflow: I'm using the double click to highlight function whenever I want to hightlight references to local variables so having it select every single occurence within other tokens would be distracting. The Ctrl+D rename tool should work within tokens though because it allows you some hacking that wouldn't be possible otherwise.

davidhealey commented 10 months ago

I'm using the double click to highlight function whenever I want to hightlight references to local variables

Me too

aaronventure commented 10 months ago

Fair point. But Sublime allows you to skip the last highlighted instance with CTRL+K, and go back with CTRL+U.

Would having matching token selection like I described at CTRL+SHIFT+D be too much of an ask?