search

christophhart / HISE

The open source framework for sample based instruments
http://hise.audio
Other
1.04k stars 122 forks source link

[bug] Table envelopes always jump after attack completes #471

Closed davidhealey closed 6 months ago

davidhealey commented 9 months ago

If the last node of the attack envelope is not 1 or 0 then when the end of the table is reached the envelope will jump to 1, even if the note is still held down.

ZPnGU7s

Forum thread - https://forum.hise.audio/topic/7183/bug-table-envelopes-always-jump-after-attack-completes

Removing this line solves the issue, but I don't know if that will cause other problems... https://github.com/christophhart/HISE/blob/develop/hi_core/hi_modules/modulators/mods/TableEnvelope.cpp#L324

aaronventure commented 9 months ago

Man, you've been after this for a year now, even found and tested the solution yourself, almost feels like Chris is just fucking with you 😂