christophhart / HISE

The open source framework for sample based instruments
http://hise.audio
Other
1.01k stars 116 forks source link

Switching wavetable files causes HISE to crash when there is a pitch modulator present and sound is playing. #502

Closed RastaChess closed 3 months ago

RastaChess commented 5 months ago

HISE crashes when there is an active pitch modulator in the chain and you try to switch wavetable files (while sound is playing).

I should note that the crash happens with the compiled plugin as well.

This one is a big one for me because switching wavetables is at the core of my project.

I tried bypassing the issue by:

  1. Zeroing out the intensity of the pitch mod before the callback switch and recalling it after.
  2. Bypassing the entire pitch modulator before the callback switch.
  3. MidiMuting note before the switch.
  4. allNotesOff(); before the switch.
  5. Bypassing the Wavetable Synth before the switch
  6. All of the above at the same time.

So long as there is sound playing, the crash happens.

I posted a snippet on the forum.

https://forum.hise.audio/topic/9421/switching-wavetable-files-causes-crash-when-there-is-a-pitch-modulator-present

christoph-hart commented 3 months ago

Should be fixed with 185a1cd9e4cc0ba7d73faa0992c5dfa8a24e1176