search

christophlehmann / imageoptimizer

TYPO3 Extension for lossless image optimization with binaries of your choice.
43 stars 22 forks source link

11 LTS Support #48

Closed dennismetz closed 2 years ago

dennismetz commented 3 years ago

Do you plan to release a version for 11 LTS Support?

christophlehmann commented 3 years ago

When someone creates a PR ;)

christophlehmann commented 3 years ago

There are some errors which need to be fixed.

 ------ ----------------------------------------------------------------------- 
  Line   Classes/ConfigurationTest.php                                          
 ------ ----------------------------------------------------------------------- 
  21     Property Lemming\Imageoptimizer\ConfigurationTest::$objectManager has  
         unknown class TYPO3\CMS\Extbase\Object\ObjectManager as its type.      
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols     
  30     Class TYPO3\CMS\Extbase\Object\ObjectManager not found.                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols     
  35     Method Lemming\Imageoptimizer\ConfigurationTest::testCommand() has no  
         return typehint specified.                                             
  35     Method Lemming\Imageoptimizer\ConfigurationTest::testCommand() has     
         parameter $params with no typehint specified.                          
 ------ ----------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------- 
  Line   Classes/OptimizeImageService.php                                      
 ------ ---------------------------------------------------------------------- 
  55     Method Lemming\Imageoptimizer\OptimizeImageService::process() should  
         return bool but empty return statement found.                         
  118    Method Lemming\Imageoptimizer\OptimizeImageService::reset() has no    
         return typehint specified.                                            
 ------ ---------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------- 
  Line   ext_localconf.php                                                   
 ------ -------------------------------------------------------------------- 
  3      Constant TYPO3_MODE not found.                                      
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ --------------------------------------------------------------------
christophlehmann commented 3 years ago

I created the branch typo3-11-support for PRs