Added methods to test the opposite conditions (fixes issue #14)

christophrumpel / missing-livewire-assertions

Adding the missing Livewire assertions to your Laravel project

MIT License

136 stars 25 forks source link

Added methods to test the opposite conditions (fixes issue #14) #15

Closed fefo-p closed 2 years ago

fefo-p commented 2 years ago

Using PHPUnit::assertMatchesRegularExpression and assertStringNotContainsString the following assertion methods were created.

Code is mostly duplicated, as I didn't want to make a major change, but logic could be extracted to protected methods to avoid duplication.

assertPropertyNotWired
assertPropertyNotEntangled
assertMethodNotWired
assertMethodNotWiredToForm
assertDoesNotContainLivewireComponent
assertDoesNotContainBladeComponent
assertDoNotSeeBefore

fefo-p commented 2 years ago

@christophrumpel if you want no changes and are not interested in adding this, please close this PR / let me know so I can move on with my own implementation. Thanks!

christophrumpel commented 2 years ago

Hey. I like it. I just asked a question about it in the issue you closed. Can you take a look?

fefo-p commented 2 years ago

@christophrumpel just in case you missed it, I reopened the issue with a message

christophrumpel commented 2 years ago

Just back from vacation. Thanks a lot for the PR 👍