christophwaibel / GH_Solar_V2

Solar irradiation model plug-in for Rhinoceros Grasshopper. Version 2.
GNU General Public License v3.0
5 stars 0 forks source link

39 irradiance bug #40

Closed christophwaibel closed 1 year ago

christophwaibel commented 1 year ago

closes #39

the problem was in the Perez diffuse irradiation calculation. The sky brightening factor delta was not capped to max 1 earlier, but it should be. To use ChatGPTs words:

_The sky brightness factor in the Perez model, also known as the diffuse horizontal irradiance (DHI) ratio, is defined as the ratio of the diffuse horizontal irradiance to the extraterrestrial irradiance. The value of the DHI ratio can vary from 0 to 1, with 0 indicating a completely clear sky with no scattering of sunlight and 1 indicating a completely overcast sky with no direct sunlight reaching the surface.

Therefore, the sky brightness factor or DHI ratio in the Perez model cannot be larger than 1, as it represents the ratio of the scattered and diffuse light to the total amount of sunlight reaching the surface._

Also changed the air mass model to Kasten Young 1989, which is the default model according to https://pvpmc.sandia.gov/PVLIB_Matlab_Help/