christosangelopoulos / fzffm

GNU Affero General Public License v3.0
1 stars 1 forks source link

[REQUEST] Support file preview in most common terminal mualtors #3

Open thealio opened 1 year ago

thealio commented 1 year ago

Hi of course, having file previews (text, images ,maybe video thumbnails, pdf) for all the most common terminals should be great. I'll try also to work myself on this

christosangelopoulos commented 1 year ago

Hello, I have managed to have thumbnail support for all terminals already. It is managed using uebrzug, overcoming an issue with transparency, which is not handled well by ueberzug. The bad thing is that ueberzug was finally archived by its author. I will update ffzm including this all terminal image support, and I would be grateful if you reissued the pull requests. As I have little experience with git (and programming generally for that matter), I am grateful for your input, and I hope I have your opinion again.

christosangelopoulos commented 1 year ago

I have imported the repo of this script's version that supports thumbnail in all terminals here https://gitlab.com/christosangel/uberfuzz. Feel free to give your input!

christosangelopoulos commented 1 year ago

Finding difficulties importing original existing repo in github, I have made it public here: https://gitlab.com/christosangel/uberfuzz I have been making various changes, like creating a install_uberfuzz.sh to make installation process easier, replacing if else conditionals with case, etc.

thealio commented 1 year ago

Hi @christosangelopoulos Dunno why , uberfuzz didn't open file and folders in my system with alacritty. I add the Ueberzug stuff directly into fzffm.sh , it seems to works pretty well on alacritty. Let me know if this new code is in conflict with the kitty stuff lines, and if it works on kitty terminal. Thank you

christosangelopoulos commented 1 year ago

Hello @thealio Uberfuzz script works in all terminals, including kitty. Can you be more specific on your issue? Is it not working at all, or is the thumbnail issue not functioning? First of all I would make sure that uberzug is up and running, because since the author archived the project, it can be tricky to install.

christosangelopoulos commented 1 year ago

Please note that thera are a few differences in the README.md of uberfuzz and fzffm. Also there are differences in the installation, and the code itself. Install the script from the start in order for it to function.

thealio commented 1 year ago

Please note that thera are a few differences in the README.md of uberfuzz and fzffm. Also there are differences in the installation, and the code itself. Install the script from the start in order for it to function.

I think that's my fault. I didn't use the install script, I just execute uberfuzz.sh

thealio commented 1 year ago

Please note that thera are a few differences in the README.md of uberfuzz and fzffm. Also there are differences in the installation, and the code itself. Install the script from the start in order for it to function.

I think that's my fault. I didn't use the install script, I just execute uberfuzz.sh

Fixed now works

christosangelopoulos commented 1 year ago

Great, as it should! I think it would be a good ideato update the README, just copy the one in gitlab. Also, another great idea is to add some consistent guidance for anyone who wishes to install uberzug. I wish I had done it myself, but in the past it was much easier.

christosangelopoulos commented 6 months ago

This is a leaner, similar project, I have added ueberzugpp support for images, check it out: basht