search

chrisvans / onbaristawebapp

Web App for Baristas to check in when they are on bar
0 stars 1 forks source link

Barista Checkin Back-end #4

Closed AJLeonardi closed 11 years ago

AJLeonardi commented 11 years ago

currently outTime cannot be blank, and so when the barista checks in, both inTime and outTime are set.

We need to make outTime optional, and we need to only set it when the barista Checks Out.

When we do this -- we'll have to update the "isCheckedIn" logic to filter based on barista, and a null outTime value.

chrisvans commented 11 years ago

Making outTime optional seems to be quite hard. How about only showing the outTime when the checkout occurs? We can have an outTime variable updated, but if it's not shown, it won't matter what it is.

chrisvans commented 11 years ago

Actually, figured it out. As an argument, null=True for the outTime attribute allows a NULL value for the database.

AJLeonardi commented 11 years ago

Oop sorry, I did this with midi last night on his branch. You'll want both null=True and blank=True

I think one's for the database, and one's for form validation -- but not 100% clear.

chrisvans commented 11 years ago

Yeah, null=True is for the database, blank=True is for the form validation. I assumed we'd never use a form input for inTime/outTime so I only updated it as null=True.