search

chrisvans / onbaristawebapp

Web App for Baristas to check in when they are on bar
0 stars 1 forks source link

All Companies does not populate properly on Baristas tab or Manage Favs tab #45

Closed chrisvans closed 11 years ago

AJLeonardi commented 11 years ago

there has to be a way to cache this information, so we're not fetching it and passing it every time we load a page.

Also, we probably shouldn't be showing this left nav thing for the manage favs, or baristas tab -- no?

chrisvans commented 11 years ago

For the manage favs, no. For the baristas tab, maybe. There are times when you would be working at another location, and a lot of baristas I know work in 2 - 3 places.

This looks like a problem with the dictionary that is passed through. We could either cache it, or create methods in the models, and make the dictionary a permanent reference to the methods - rather than running if checks and variable assignments within the view. I'm not sure which is more efficient, but the code will be a lot easier to edit.

AJLeonardi commented 11 years ago

ah I get it.

Cool. I plan on finishing up the assignment tonight, and then hopefully working on this a bit (sorry I've been MIA this week)

On Wed, Feb 27, 2013 at 4:46 PM, chrisvans notifications@github.com wrote:

For the manage favs, no. For the baristas tab, maybe. There are times when you would be working at another location, and a lot of baristas I know work in 2 - 3 places.

This looks like a problem with the dictionary that is passed through. We could either cache it, or create methods in the models, and make the dictionary a permanent reference to the methods - rather than running if checks and variable assignments within the view. I'm not sure which is more efficient, but the code will be a lot easier to edit.

— Reply to this email directly or view it on GitHubhttps://github.com/chrisvans/onbaristawebapp/issues/45#issuecomment-14202216 .

chrisvans commented 11 years ago

Now they show up on the baristas tab, and there is no nav bar on the manage favorites tab. However, there is a white space left behind on the manage favorites tab. Also, the links on the baristas tab just lead back home right now. So, incomplete.

chrisvans commented 11 years ago

How do you pass an argument properly through the links? Like how it is set up right now - the company ID is passed through to the homepage, and then used to populate the locations list.

chrisvans commented 11 years ago

Thursday's work cleared this issue.