search

chrisvdm / redwoodjs-stripe

A Redwood/Stripe integration made easy
MIT License
46 stars 8 forks source link

fix: remove `@redwoodjs/*` packages from `peerDependencies` to reduce bundle size #84

Closed jtoar closed 1 year ago

jtoar commented 1 year ago

Before https://github.com/chrisvdm/redwoodjs-stripe/pull/83, let's try this. The intention in listing @redwoodjs/core and /web in peerDependencies is right, but it seems like Netlify's zisi (zip-it-and-ship-it) bundler is interpreting this line as "I guess I should include all of @redwoodjs/core in the lambda", which definitely isn't what we want since it's mostly devDependencies. We can figure out version compatibility another way. Locally this reduced the bundle size from 200MB+ to ~27MB.

@chrisvdm as the next step, do you think we could merge this, release a new RC, and see if we can deploy?

chrisvdm commented 1 year ago

It's so odd that Netlify does that. but yeah lets give that a go