search

chrisvest / stormpot

A fast object pool for the JVM
http://chrisvest.github.io/stormpot/
Apache License 2.0
350 stars 41 forks source link

Fix potential overflow bugs in timeout computations #133

Closed chrisvest closed 4 years ago

chrisvest commented 4 years ago

Fixes https://github.com/chrisvest/stormpot/projects/1#card-37883679

codecov[bot] commented 4 years ago

Codecov Report

Merging #133 into 3.1 will decrease coverage by 0.34%. The diff coverage is 90.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.1     #133      +/-   ##
============================================
- Coverage     95.42%   95.07%   -0.35%     
  Complexity      317      317              
============================================
  Files            30       31       +1     
  Lines           808      812       +4     
  Branches         89       89              
============================================
+ Hits            771      772       +1     
- Misses           23       25       +2     
- Partials         14       15       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/stormpot/Timeout.java 65.21% <0.00%> (-9.79%) 9.00 <0.00> (-3.00)
src/main/java/stormpot/BAllocThread.java 96.42% <100.00%> (-1.05%) 71.00 <0.00> (-1.00)
src/main/java/stormpot/BSlot.java 83.78% <100.00%> (+1.35%) 28.00 <1.00> (+1.00)
src/main/java/stormpot/BlazePool.java 98.16% <100.00%> (+0.03%) 52.00 <7.00> (ø)
src/main/java/stormpot/DirectAllocatorProcess.java 91.48% <100.00%> (+0.37%) 14.00 <0.00> (ø)
src/main/java/stormpot/NanoClock.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
chrisvest commented 4 years ago

The drop in coverage is because the deprecated methods are not used anymore. Merging anyway.