search

chrisvest / xxv

The XXV visual hex viewer for the terminal.
https://chrisvest.github.io/xxv/
86 stars 5 forks source link

Update cursive to 0.14 #16

Closed gyscos closed 4 years ago

chrisvest commented 4 years ago

Thanks for taking this on!

Travis failed on Windows. Restarted the 2 months old green build of master to see if its a change in the build environment. (The GitHub Actions builds have never been green; they're missing the ncurses dependency)...

Restarted old-master build failed, so looks like something in the build environment changed.

gyscos commented 4 years ago

Forgot to mention I also ran rustfmt on the affected files, which increased a bit the diff... If you have a preferred style, you can try and see if it can be achieved with some rustfmt settings. Keeping a rustfmt.toml in the root of the repo will make autoformatters follow it :)

gyscos commented 4 years ago

The GitHub Actions builds have never been green; they're missing the ncurses dependency

One solution could be to use the crossterm backend instead; it seems to be a reliable pure-rust cross-platform one.

chrisvest commented 4 years ago

I can give crossterm another try, and also see if https://github.com/gyscos/cursive/issues/352 has been fixed.

chrisvest commented 4 years ago

First impressions is that performance is worse, at least on Linux, with noticeable flicker even in release builds. We'll see how the build fares in #17.