chrisvfritz / prerender-spa-plugin

Prerenders static HTML in a single-page application.
MIT License
7.32k stars 634 forks source link

Looking for maintainers! #477

Open JoshTheDerf opened 2 years ago

JoshTheDerf commented 2 years ago

As support for server-side rendering has matured, I've had little reason to revisit pre-rendering in any of my projects. As a result, I've had no need of this library for my own purposes and have let it fall by the wayside.

At this point, I'd be happy to transfer ownership of the project to someone who still has active use for pre-rendering and would be willing to bring this repo up back up to date.

If you sign on as a maintainer, the core prerenderer library will also be under your purview.

Reply here if you're interested. :)

fouronnes commented 2 years ago

Thank you for a great plugin! I hope you find a good maintainer to step up. Server-side rendering and build-time prerendering are two different technologies, and I hope this project can live on! 👍

cstavaru commented 2 years ago

I think prerendering is still the most important of the two. Server-side rendering is just a stopgap dictated by Google's technology limitations. Prerendering is the correct solution until Google's crawlers (and its developers) will become smart enough.

There is simply no reason for server-side rendering of front-end applications because there is fundamentally a lot of traffic duplication and processing power centralization when it should be (and will be) the other way around. Speed of light will also not change anytime soon.

People have more and more powerful devices that should and must be used to offload as much processing as possible. Also, a website should not depend on its backend if at all possible.

This being said, I have a CloudFront distribution with an S3 bucket origin on which I would like to host my SPA. Spinning up an AWS way to run server-side code creates unnecessary dependencies, is cumbersome, expensive and can easily be insecure.

Thanks for supporting this project !

JoshTheDerf commented 2 years ago

In my experience, you can usually use server side renderingto prerender, making prerendering mostly irrelevant. Except that it can work without being particularly framework-dependent. :/

On Sat, Jan 22, 2022, 9:31 PM cstavaru @.***> wrote:

I think prerendering is still the most important of the two. Server-side rendering is just a stopgap dictated by Google's technology limitations. Prerendering is the correct solution until Google's crawlers (and its developers) will become smart enough. There is simply no reason for server-side rendering of front-end applications because there is fundamentally a lot of duplication and processing power centralization when it should be (and will be) the other way around. A website should not depend on its backend if at all possible.

This being said, I have a CloudFront distribution with an S3 bucket on which I would like to host my SPA. Spinning up an AWS way to run server-side code is cumbersome, expensive and (in the case of EC2) insecure.

Thanks for supporting this project !

— Reply to this email directly, view it on GitHub https://github.com/chrisvfritz/prerender-spa-plugin/issues/477#issuecomment-1019399345, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMW76YBWXEZPKQFEYZGMVDUXNR6ZANCNFSM5KBFHZAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

squareloop1 commented 2 years ago

In my experience, you can usually use server side renderingto prerender, making prerendering mostly irrelevant. Except that it can work without being particularly framework-dependent. :/

Sadly I can't share this experience (besides SSR being framework dependent 😅). Prerendering and SSR are two completely different things. SSR is server rendering on the fly and hydrating on the client while prerendering is creating static html files.

Most SSR frameworks don't let you prerender static html files which makes this library still relevant. I e.g. use it to prerender html files in the webpack build step for PurgeCss to look for used CSS classes to prevent false positives while purging CSS which is working great. I could not do this with SSR.

fouronnes commented 2 years ago

Hey @JoshTheDerf, I'm interested in serving as maintainer for a while. I was hoping someone more experienced would volunteer, but since no one has I want to give it a try. I'm just a volunteer with limited free time, but I'm using prerender-spa-plugin in production, and I'm happy to try to take the repo into a better state. I don't have much experience for this, but my goals are simple:

Let me know, cheers.

JoshTheDerf commented 2 years ago

Hey @JoshTheDerf, I'm interested in serving as maintainer for a while. I was hoping someone more experienced would volunteer, but since no one has I want to give it a try. I'm just a volunteer with limited free time, but I'm using prerender-spa-plugin in production, and I'm happy to try to take the repo into a better state. I don't have much experience for this, but my goals are simple:

  • Clean up open issues and PRs
  • Fix webpack 5 compatibility
  • Keep looking for another co-maintainer if anyone is interested
  • Setup a simple CI with GitHub actions
  • Start reviewing accepting PRs
  • Make a new release

Let me know, cheers.

Awesome, glad to hear it! I'll add you to the prerenderer project. I'll need to contact @chrisvfritz to see if he can add you as a maintainer here, as I don't have full access to the repository settings. Will also need to give you access to NPM releases.

fouronnes commented 2 years ago

@JoshTheDerf @chrisvfritz any update on this?

mikob commented 2 years ago

Note for the next maintainer: This fork worked for me: https://github.com/RoboFinance/prerender-spa-plugin

Tofandel commented 2 years ago

I'd be happy to become a maintainer, I actually already maintain my own fork which was fully rewritten for webpack 5 https://github.com/Tofandel/prerender-spa-plugin-next

JoshTheDerf commented 2 years ago

@chrisvfritz and/or @drewlustro, Could maintainership be transferred to @fouronnes and @Tofandel please?

LaisGalvao commented 2 years ago

I'm interested to becoming a voluntary maintainer too!

mikob commented 2 years ago

The one I mentioned here disappeared, but I've found other forks that work. @Tofandel I'm still having issues with yours. It's not rendering the .html pages for vue routes in vue 3. It only renders one index.html and the relevant css, and js.

Tofandel commented 2 years ago

@mikob Can you open an issue on the fork with some info about your setup (vue cli config and main.js)? I'm myself using it in projects with @vue/cli and they all work correctly

ziagit commented 1 year ago

@mikob Can you open an issue on the fork with some info about your setup (vue cli config and main.js)? I'm myself using it in projects with @vue/cli and they all work correctly

Is this package working with Vue installed in Laravel? my Vue app is not created by Vue/cli, if It is possible please share the steps how to do that. thanks.

Tofandel commented 1 year ago

I took over maintenance of the whole @prerenderer repo, there you'll find a @prerenderer/webpack-plugin package or a @prerenderer/rollup-plugin for vite, as such maybe it's a good idea to mark this npm package as deprecated, redirect there and archive this github repo